Skip to content

Tracking PR for 0.14.0-alpha.2#2539

Draft
mmagician wants to merge 4 commits intorelease/v0.14.0-alphafrom
agglayer
Draft

Tracking PR for 0.14.0-alpha.2#2539
mmagician wants to merge 4 commits intorelease/v0.14.0-alphafrom
agglayer

Conversation

@mmagician
Copy link
Collaborator

Only AggLayer changes should be merged to release/v0.14.0-alpha branch for now

@mmagician mmagician added agglayer PRs or issues related to AggLayer bridging integration pr-from-maintainers PRs that come from internal contributors or integration partners. They should be given priority labels Mar 3, 2026
mmagician and others added 3 commits March 4, 2026 15:57
* chore: new SPEC file

* feat: entities and permissions

* feat: contracts and public interfaces

* feat: integrate contract storage into sec 2.

* feat: notes, incl properties, storage, consumption

* feat: match Rust fields for note spec

* docs: update SPEC.md for resolved issues and current bridge design

* docs: address review comments on SPEC.md

- Update baseline to "to-be-tagged v0.14-alpha"
- Add explanation for why native claim amount is verified (avoids
  expensive U256 division inside the VM)
- Simplify addr output notation to addr(5)

https://claude.ai/code/session_01UDgsAS2j2CFrTLsDoLiSUN

* chore: update docs to match latest agglayer branch

* docs(AggLayer): Ethereum <> Miden address conversion specification (#2513)

* docs: add Section 5 — Ethereum ↔ Miden address conversion spec

Comprehensive specification of the address conversion encoding between
Ethereum 20-byte addresses and Miden AccountId (two field elements),
covering the embedded format, MASM limb representation, Rust and MASM
conversion procedures, endianness details, and roundtrip guarantees.

Addresses #2229

https://claude.ai/code/session_01YabAhXZeStAkKkYwBcXXFh

* Apply suggestions from code review

Update crates/miden-agglayer/SPEC.md

Update crates/miden-agglayer/SPEC.md

Update crates/miden-agglayer/SPEC.md

* fix: EthAddressFormat::from_account_id usage

* docs: clean up address conversion

---------

Co-authored-by: Claude <noreply@anthropic.com>

* chore: add sec 4. placeholder

* chore: add a note about encoding of u32s in note storage

---------

Co-authored-by: Claude <noreply@anthropic.com>
* feat: impl storage helpers for AggLayerBridge

* refactor: add account code check

* refactor: rework the procedures check

* chore: move bridge and faucet to their own modules

* feat: add storage helpers for the agglayer faucet

* test: impl test for helpers, fix bug

* chore: remove debug log

* refactor: update the way constants are generated

* chore: remove debug assert, update comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agglayer PRs or issues related to AggLayer bridging integration pr-from-maintainers PRs that come from internal contributors or integration partners. They should be given priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants